-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby does not build against cucumber-messages 25.0.0 #256
Comments
CI does this constantly without fail. Do you have a more precisely specified reproducer? |
I'm one of the ruby maintainers for Arch Linux and we are currently rebuilding all packages against ruby 3.2 in our [extra-staging] repository and there I saw the issue. You can have a look at https://archlinux.org/packages/?page=1&sort=&repo=Core-Staging&repo=Extra-Staging&q=ruby&maintainer=&flagged= where we list all packages currently in staging. Our internal ticket with a patch to fix the issue: https://gitlab.archlinux.org/archlinux/packaging/packages/ruby-cucumber-gherkin/-/issues/1 The current definition of the package which is working now: https://gitlab.archlinux.org/archlinux/packaging/packages/ruby-cucumber-gherkin/-/blob/main/PKGBUILD which includes this patch to work around this issue: https://gitlab.archlinux.org/archlinux/packaging/packages/ruby-cucumber-gherkin/-/blob/main/ruby-cucumber-gherkin_fix_tests.patch |
I should mention I tried to build with version |
I think https://gitlab.archlinux.org/archlinux/packaging/packages/ruby-cucumber-gherkin/-/issues/1#note_197356 will explain why we are having this issue. We break up the upper version constraint as we don't like to hold back packages due to dependency issues. |
Right. You are using cucumber-gherkin 28.0.0 with cucumber-messages 25.0.1 instead of 24. That explains.
I see. I'm not sure how practical that approach is, but it is yours to take. As Cucumber messages v25 was only just released. It will eventually propagate to the other dependencies in the cucumber ecosystem. @luke-hill would you potentially welcome a pull request from @Segaja to upgrade messages to 25? Or you got more things in mind. Note: Everyone one working on Cucumber is practically a volunteer. And it is the holidays, it might be a while before you have an answer. |
Currently don't have good email connectivity due to job situation. Just spotted this. I'm working on updating it now. Won't be long before a fix is in. Maybe a week - it's a tiny fix needed. FYI once this lands more updates will be needed to other cucumber libraries - I've not got around to using the latest messages yet elsewhere. cc/ @Segaja |
Hi @Segaja - This is still ongoing. Somewhere between 50 and 75% complete now. EDIT: This repo does build against later versions of messages. But the cucumber ruby "ecosystem" is somewhere between 50 and 75% |
π What did you see?
β What did you expect to see?
Clean running tests
π¦ Which tool/library version are you using?
ruby 3.2.4
cucumber-messages 23.0.0
π¬ How could we reproduce it?
Just try to run the tests of the 28.0.0 release of this gem against the named defendencies
π Any additional context?
No response
The text was updated successfully, but these errors were encountered: