-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite #6
Comments
We still need a few basic coverage tests. I added one in #14, but more are needed. @TomNicholas can you suggest a few we could add? Perhaps ones that we adapt from the xarray test suite (since #8 is some way off). |
Yeah I think a place to start would just to have at least one test per method in the ChunkManager. I.e. chunk, rechunk, reduction, apply_ufunc, store, to_zarr, scan? Etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently we barely test that xarray objects wrapping cubed arrays actually compute correctly when called upon. Instead we are basically assuming that:
(a) cubed supporting the array API
(b) xarray supposedly correctly calling the array API
(c) chunk-aware functions being re-routed through the
ChunkManagerEntrypoint
is together enough for most operations to "just work".
In practice that won't be enough to ensure successful computation on cubed arrays (see list of known problems in the readme), and a more comprehensive testing approach is needed.
The long-term best way to fully test this integration would be to finish creating the framework suggested in pydata/xarray#6894, then import and use that in this repository. Unfortunately there is still a fair bit of work to get to that point (especially finishing pydata/xarray#6908.
cc @tomwhite
The text was updated successfully, but these errors were encountered: