Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS references #60

Closed
vissarion opened this issue Sep 25, 2024 · 8 comments
Closed

JOSS references #60

vissarion opened this issue Sep 25, 2024 · 8 comments

Comments

@vissarion
Copy link

This is part of openjournals/joss-reviews#6698

  1. Some DOIs are missing. e.g.
  1. I think the following ref is not needed Kelley, C. T. (2024b). MultiPrecisionArrays.jl. https://github.com/ctkelley/MultiPrecisionArrays.jl. https://doi.org/10.5281/zenodo.7521427

  2. In ref Kelley, C. T. (2022c) the journal title/pages/issue etc are missing.

@ctkelley
Copy link
Owner

ctkelley commented Sep 25, 2024 via email

@ctkelley
Copy link
Owner

ctkelley commented Sep 25, 2024 via email

@ctkelley
Copy link
Owner

ctkelley commented Sep 25, 2024 via email

@ctkelley
Copy link
Owner

I fixed the "iteration loop" wording.

@ctkelley
Copy link
Owner

ctkelley commented Sep 25, 2024 via email

@vissarion
Copy link
Author

  1. Yes, it is a reference to the package under submission which eventually will be published and get a DOI (and also a zenodo link) I think it is confusing to have two links and two DOIs for the same package MultiPrecisionArrays.jl.
  2. kelley:2022c is a book in the pdf, the following information are from SIAM, could be added but I think it is OK as is since it is a book
Published:2022
ISBN:978-1-61197-726-4
eISBN:978-1-61197-727-1
https://doi.org/10.1137/1.9781611977271
Book Series Name:Fundamentals of Algorithms

@ctkelley
Copy link
Owner

I've eliminated the reference to the package.

I tried your changes to the citation to the book and got errors from GitHub actions. I'll stick with what I had if that is ok.

@vissarion
Copy link
Author

Thanks for the efforts, references look good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants