Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

software_with_any2 excludes MAGIC-only events? #74

Closed
jsitarek opened this issue Jun 21, 2022 · 3 comments
Closed

software_with_any2 excludes MAGIC-only events? #74

jsitarek opened this issue Jun 21, 2022 · 3 comments

Comments

@jsitarek
Copy link
Collaborator

Hi @YoshikiOhtani

I'm curious about this cut:

elif irf_type == 'software_with_any2':
df_events.query('(combo_type > 0) & (magic_stereo == True)', inplace=True)

elif irf_type == 'software_with_any2':
df_events.query('combo_type > 0', inplace=True)

The combo_type cut excludes the events in which you have both MAGIC telescopes, but no LST1.
Looking at MCs, this is pretty rare, but I'm wondering why such a cut was applied? Is is performance-driven to exclude very bad events, or a technical issue that those events will not have some LST1 information needed?

@YoshikiOhtani
Copy link
Collaborator

YoshikiOhtani commented Jun 22, 2022

Hi @jsitarek, it is originally introduced because I decided not to keep the MAGIC-stereo events which are NOT coincident with LST-1 after the event coincidence search. This is because from the MC study LST-1 should see most of MAGIC stereo-trigger gamma-ray events, so the most of the non-coincident MAGIC events should be hadron. Thus, when creating the IRFs I excluded the MAGIC-stereo events from DL2 MC data.

However, the ratio of the MAGIC-stereo gamma-ray events over the whole stereo events depends on event cuts, e.g., leakage cut would increate the ratio. So it may be good to reconsider about this, what is the best way to treat them.

@YoshikiOhtani
Copy link
Collaborator

As I reported yesterday, now the pipeline keeps also the MAGIC-stereo events taken during the LST observation time period but not coincident with any LST-1 events. The fraction of those events are relatively high, so it may be worth using the events for the analysis now. However, the problem is that with the current training scheme we do not have enough training samples for the MAGIC-stereo combination type. One alternative solution is to use the combo_type parameter in the training instead of separating RFs by the combination types, and in that case we can apply well trained RFs to those MAGIC-stereo events. This is related to the issue #27, so at some point it would be worth testing this scheme, and check how the performance changes.

@jsitarek
Copy link
Collaborator Author

closing this as outdated because there is not anymore "software_with_any2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants