Locale template tidying

[cyanliu-zzz]

Are the English strings accurate to what's currently on the site? I've noticed a couple of what I think are inconsistencies ("Request an item" in the template vs. "Request new item" on the site, on the menu when a user has signed in). I haven't quite finished setting up my dev environment but I was wondering if it'd be worthwhile to do a quick sweep and just tidy up these little things as soon as I do.

Unfortunately I'm not too familiar with the stack, so I don't want to break anything if adjusting the template would render all of the current translations void somehow :(

[ppannuto]

They've likely fallen a little bit out of date. I'm not terribly familiar with the translation tools either, but I _think_ that re-running pot-create (see README.translation) should just add the new strings. It's possible that some strings aren't marked for translation, which would be a bug. Translation is done with the underscore function, like so https://github.com/um-cseg/chez-betty/blob/master/chezbetty/templates/public/index.jinja2#L24 -- if some strings don't have that then the wont get translated. Finally, stuff like "request an item" and "request new item" are basically the same. Consolidating those to be the same message to lower the translation burden would be great.

…

On Mon, Feb 13, 2017 at 11:45 AM Christina Liu ***@***.***> wrote: Are the English strings accurate to what's currently on the site? I've noticed a couple of what I think are inconsistencies ("Request an item" in the template vs. "Request new item" on the site, on the menu when a user has signed in). I haven't quite finished setting up my dev environment but I was wondering if it'd be worthwhile to do a quick sweep and just tidy up these little things as soon as I do. Unfortunately I'm not too familiar with the stack, so I don't want to break anything if adjusting the template would render all of the current translations void somehow :( — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#304>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAUt3n-gA0DAJGH_PkRuy9wujlHjf6hYks5rcIijgaJpZM4L_cBy> .

[cyanliu-zzz]

I tried running pot-create -c lingua.config -o chezbetty/locale/betty.pot chezbetty, but it seemed to generate a template that is significantly shorter than the existing one :/ I'll also run through the jinja templates to make sure there are underscore functions everywhere necessary, but for the ones I just quickly perused, there do seem to be underscore functions but nothing in the generated betty.pot

(and yeah, I figured a template that is 2 years old might be at least a bit outdated :P)

[cyanliu-zzz]

So it seems that the command doesn't generate msgid and msgstrs from jinja templates. I'm not really sure why, but I'm super unfamiliar with the tools so I'm wondering if this is an issue with lingua.config or the pot-create command itself

[ppannuto]

Not sure, I remember there being a little funniness around the jinja stuff, there's this interesting bit in the repo:

[-bash] Tue 28 Feb 02:46 [[master] ~/code/chez-betty]
$ cat lingua.config
[extensions]
.jinja2 = babel-jinja2

which is maybe out of date / not right any more and needs some kind of change/update