Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

feat: Added Transition for better question submit flow #253

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adilwahla
Copy link
Contributor

@adilwahla adilwahla commented Oct 5, 2022

🛠️ Fixes Issue

Fixes #216

➕ Changes Introduced

Added circular bar transition that shows question being submitting

  • Added component css for transition css spinner class
  • used setstate for transitions

📄 Note To Reviewers

the value for transition is 5k ms what do you all think should we reduce it little bit?

📷 Screenshots

https://www.awesomescreenshot.com/video/11525877?key=371821889405da656419b58003392b21

Copy link
Contributor Author

@adilwahla adilwahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I hope my hacktoberfest pull request is gonna merge :)

setLoading(true);
setTimeout(() => {
setLoading(false);
}, 5000);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ykdojo if you think 5000 value is bit more we can reduce it

@vercel
Copy link

vercel bot commented Oct 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
defaang ✅ Ready (Inspect) Visit Preview Oct 6, 2022 at 4:10AM (UTC)

@github-actions github-actions bot added the title needs formatting Edit PR title to be in line with conventional commit message label Oct 5, 2022
@adilwahla adilwahla changed the title Added Transition Added transition for better question submit flow Oct 5, 2022
@adilwahla adilwahla changed the title Added transition for better question submit flow feat: Added transition for better question submit flow Oct 5, 2022
@adilwahla adilwahla changed the title feat: Added transition for better question submit flow [FEATURE] Better question submission flow Oct 5, 2022
@adilwahla adilwahla changed the title [FEATURE] Better question submission flow feat: Better question submission flow Oct 5, 2022
@adilwahla adilwahla changed the title feat: Better question submission flow fix: Better question submission flow Oct 5, 2022
@adilwahla adilwahla changed the title fix: Better question submission flow feat: Added Transition Oct 5, 2022
@adilwahla adilwahla changed the title feat: Added Transition fix: Added Transition for better question submit flow Oct 5, 2022
@adilwahla adilwahla changed the title fix: Added Transition for better question submit flow feat: Added Transition for better question submit flow Oct 5, 2022
Copy link
Contributor Author

@adilwahla adilwahla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolving PR title issue

@github-actions github-actions bot removed the title needs formatting Edit PR title to be in line with conventional commit message label Oct 5, 2022
@ykdojo
Copy link
Collaborator

ykdojo commented Oct 5, 2022

@adilwahla I added a comment on the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Better question submission flow
2 participants