This repository has been archived by the owner on Jan 20, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 120
feat: Added Transition for better question submit flow #253
Draft
adilwahla
wants to merge
2
commits into
csdojo-defaang:main
Choose a base branch
from
adilwahla:Transition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adilwahla
commented
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, I hope my hacktoberfest pull request is gonna merge :)
setLoading(true); | ||
setTimeout(() => { | ||
setLoading(false); | ||
}, 5000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ykdojo if you think 5000 value is bit more we can reduce it
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
title needs formatting
Edit PR title to be in line with conventional commit message
label
Oct 5, 2022
adilwahla
changed the title
Added Transition
Added transition for better question submit flow
Oct 5, 2022
adilwahla
changed the title
Added transition for better question submit flow
feat: Added transition for better question submit flow
Oct 5, 2022
adilwahla
changed the title
feat: Added transition for better question submit flow
[FEATURE] Better question submission flow
Oct 5, 2022
adilwahla
changed the title
[FEATURE] Better question submission flow
feat: Better question submission flow
Oct 5, 2022
adilwahla
changed the title
feat: Better question submission flow
fix: Better question submission flow
Oct 5, 2022
adilwahla
changed the title
feat: Added Transition
fix: Added Transition for better question submit flow
Oct 5, 2022
adilwahla
changed the title
fix: Added Transition for better question submit flow
feat: Added Transition for better question submit flow
Oct 5, 2022
adilwahla
commented
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resolving PR title issue
github-actions
bot
removed
the
title needs formatting
Edit PR title to be in line with conventional commit message
label
Oct 5, 2022
@adilwahla I added a comment on the issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes Issue
Fixes #216
➕ Changes Introduced
Added circular bar transition that shows question being submitting
📄 Note To Reviewers
the value for transition is 5k ms what do you all think should we reduce it little bit?
📷 Screenshots
https://www.awesomescreenshot.com/video/11525877?key=371821889405da656419b58003392b21