Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order of normalization and log transformation in standard workflow #535

Closed
hendraet opened this issue Oct 1, 2024 · 2 comments · Fixed by #547
Closed

Change the order of normalization and log transformation in standard workflow #535

hendraet opened this issue Oct 1, 2024 · 2 comments · Fixed by #547
Labels
enhancement New feature or request good first issue Good for newcomers small

Comments

@hendraet
Copy link
Collaborator

hendraet commented Oct 1, 2024

Issue description

Currently, the standard workflow lists the normalisation preprocessing step before the log transform step. It should be the other way around.
(Otherwise this can lead to negative log intensity values, which is not completely wrong but counterintuitive).

@hendraet hendraet added enhancement New feature or request good first issue Good for newcomers small labels Oct 1, 2024
@henninggaertner
Copy link
Collaborator

I feel like we switched this once already, but can't remember from which configuration. But maybe the change got lost and didn't make it to the dev branch.

@hendraet
Copy link
Collaborator Author

hendraet commented Oct 1, 2024

I tested it on dev this morning and it wasn't switched 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers small
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants