Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocsync 0.91.0 #61

Open
hefee opened this issue Nov 29, 2013 · 11 comments
Open

ocsync 0.91.0 #61

hefee opened this issue Nov 29, 2013 · 11 comments

Comments

@hefee
Copy link
Collaborator

hefee commented Nov 29, 2013

I checked the csync.h of 0.91.0 and sw, that pyowncloud will crash. Renaming of functions, different errors etc.

@diederikdehaas
Copy link
Contributor

Couple of quick notes:

  • Could you package it for debian and put it in experimental? I don't have the knowledge/time/experience to work with the source of ocsync, but I do have the experience to switch between ocsync from testing/sid/experimental.
  • If upstream has changed the order of (error) constants (again), please open an issue upstream and link/label it here. Constants should not change values (they're named constants for a reason).
  • Request an 'API' for the owncloud client version 1.5 (it's unreasonable to ask for earlier versions) so downstream projects (=us) know what we can and can't rely on and functions don't just get renamed/removed etc

This is a great opportunity for us/me to make pyowncloud more resilient! I'd love to work on this since it's a great learning experience and I should have some time starting this sunday again and if you could give me pointers (on IRC) that would be great :-)

@hefee
Copy link
Collaborator Author

hefee commented Nov 29, 2013

Could you package it for debian and put it in experimental?

I saw these changes becaue I start packaging ocsync 0.91.0 for debian. I'm more or less ready with it but they added a new lib httpbf.a, so i have to add new packages to debian -> That mean they must go through the NEW queue -> so it will take a while :(

But you can use the ocsync package packed by the owncloud-client people:
http://software.opensuse.org/download/package?project=isv:ownCloud:community:testing&package=owncloud-client

If upstream has changed the order of (error) constants (again)

But you can easily look at the changes, if you download the git of ocsync (git://git.csync.org/users/owncloud/csync ocsync branch) and look at the changes betweeen 0.90.4 and 0.91.0:
git checkout v0.91.0
git diff v0.90.4 src/csync.h

If you have time to open an issue great! I'm away for the weekend so no time for me to handle this.

Request an 'API' for the owncloud client version 1.5

Till now we set up on ocsync and not owncloud-client, that is a BIG difference! Btw. the cmdline executable ocsync is now gone away instead owncloud-client support has an own cmdline executable. So if we want to relay on libowncloud, than it is hard to say, why you should use pyowncloud. With only needing ocsync, we can say, ok you don't need owncloud-client and no QT,... so it is less things you need to compile to have an owncloud-client.

@diederikdehaas
Copy link
Contributor

On Friday 29 November 2013 02:25:15 hefee wrote:

If you have time to open an issue great! I'm away for the weekend so no time
for me to handle this.

I'll do my best. Enjoy your weekend!

@hefee
Copy link
Collaborator Author

hefee commented Dec 9, 2013

ocsync 0.91.1 is now packaged for debian and available in experimental.

@diederikdehaas
Copy link
Contributor

Thanks, will try to work on it this week.

@diederikdehaas
Copy link
Contributor

Upgrading my virtual machines from wheezy + OC 4.0.8 to jessie + OC 5.0.13 ... and it's not going so smooth (the OC part that is) ...
After that I'll work on this issue.

@hefee
Copy link
Collaborator Author

hefee commented Jan 1, 2014

Okay ocsync 0.91.X is really nasty (progress see branch support-multiple-versions ):

  • manually init and exist the neon lib (solved)
  • the major function we use csync_propergate is deletet with 0.91.x and moved to mirall:
    • either we write an own propageter (see owncloud-client/src/mirall/owncloudpropagator.cpp)
    • look for other way to use ocsync
  • can't use old journal:
    • segfaults with old journal
ocsync-DEBUG: _csync_detect_update: Reading from database: PATH
ocsync-DEBUG: _csync_detect_update: file: PATH, instruction: INSTRUCTION_NONE <<=
csync-DEBUG: csync_vio_opendir: Reading directory ownclouds://SERVER/remote.php/webdav/PATHTO/PATH from database
ocsync-DEBUG: csync_statedb_get_below_path: SQL: SELECT phash, path, inode, uid, gid, mode, modtime, type, md5, fileid FROM metadata WHERE path LIKE('PATH/%')
ocsync-WARNING: csync_statedb_query: sqlite3_compile error: no such column: fileid - on query SELECT phash, path, inode, uid, gid, mode, modtime, type, md5, fileid FROM metadata WHERE path LIKE('PATH/%')
ocsync-ERROR: csync_dbtree_opendir: Query result list is NULL!
ocsync-ERROR: csync_ftw: opendir failed for ownclouds://SERVER/remote.php/webdav/PATHTO/PATH-  (errno 11)

@diederikdehaas
Copy link
Contributor

It would be nice if they'd stop the nasty habit of changing their database structure with each and every release :-(
Looking at csync_statedb.c doesn't make me confident that the database issues are a thing of the past either:
First doing a "SELECT * ..." and in comments they mention which fields they're interested in and then copy the values based on ordinal position to the various variables. (shakes head)

@pgrandin
Copy link

Can we reopen this bug ? 0.90 is deprecated on some distros, and at some point the upgrade will probably be needed ( example : https://bugs.gentoo.org/show_bug.cgi?id=501228 )

@csawyerYumaed
Copy link
Owner

Hi pgrandin, well #71 is essentially a duplicate of this bug #61. Hence why #71 was closed.

@pgrandin
Copy link

Ah, my bad. I got confused by the closed icon which is actually referencing #71
Apologies for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants