Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertMetadata integration test #4158

Closed
MahdiBaghbani opened this issue Sep 4, 2023 · 1 comment
Closed

Fix assertMetadata integration test #4158

MahdiBaghbani opened this issue Sep 4, 2023 · 1 comment

Comments

@MahdiBaghbani
Copy link
Contributor

The whole assertMetadata integration test is currently broken.

Expect(statRes.Info.ArbitraryMetadata.Metadata["foo"]).To(BeEmpty())

Screenshot 2023-09-04 122933

We have this access to arbitrary metadata, however it panics, using debugger shows that actually both arbitrary and canonical metadata are nil.

I'll comment them out for now since it's also not working in SM PHP app, we'll have to fix it in future.

@glpatcern
Copy link
Member

This is indeed due to a missing implementation of the PHP app, and it's tracked as sciencemesh/nc-sciencemesh#43

So I'm closing this as "duplicate"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants