From 86a5cbad1447205c992a3014cb663ecf1e4d0e8f Mon Sep 17 00:00:00 2001
From: Karthikeyan Bhargavan <karthik.bhargavan@gmail.com>
Date: Wed, 10 Jul 2024 07:44:52 -0400
Subject: [PATCH] fixed nits

---
 libcrux-ml-kem/src/ind_cca.rs   | 1 +
 libcrux-ml-kem/src/mlkem1024.rs | 1 -
 libcrux-ml-kem/src/mlkem512.rs  | 1 -
 libcrux-ml-kem/src/mlkem768.rs  | 1 -
 libcrux-ml-kem/src/types.rs     | 4 ++--
 5 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/libcrux-ml-kem/src/ind_cca.rs b/libcrux-ml-kem/src/ind_cca.rs
index 218676b1d..6874559c7 100644
--- a/libcrux-ml-kem/src/ind_cca.rs
+++ b/libcrux-ml-kem/src/ind_cca.rs
@@ -279,6 +279,7 @@ pub(crate) fn generate_keypair_unpacked<
     //        core::array::from_fn(|j| A_transpose[j][i])
     //    });
 
+    #[allow(non_snake_case)]
     let mut A = core::array::from_fn(|_i| {
         core::array::from_fn(|_j| PolynomialRingElement::<Vector>::ZERO())
     });
diff --git a/libcrux-ml-kem/src/mlkem1024.rs b/libcrux-ml-kem/src/mlkem1024.rs
index d50e0abaf..f8b605f35 100644
--- a/libcrux-ml-kem/src/mlkem1024.rs
+++ b/libcrux-ml-kem/src/mlkem1024.rs
@@ -61,7 +61,6 @@ pub type MlKem1024KeyPairUnpacked<Vector: VectorType> = MlKemKeyPairUnpacked<RAN
 // Instantiate the different functions.
 macro_rules! instantiate {
     ($modp:ident, $p:path, $vec:path, $doc:expr) => {
-        /// Provides $modp implementations of ML-KEM 1024
         #[doc = $doc]
         pub mod $modp {
             use super::*;
diff --git a/libcrux-ml-kem/src/mlkem512.rs b/libcrux-ml-kem/src/mlkem512.rs
index a0ac56ca7..561bc68bb 100644
--- a/libcrux-ml-kem/src/mlkem512.rs
+++ b/libcrux-ml-kem/src/mlkem512.rs
@@ -58,7 +58,6 @@ pub type MlKem512KeyPairUnpacked<Vector: VectorType> = MlKemKeyPairUnpacked<RANK
 // Instantiate the different functions.
 macro_rules! instantiate {
     ($modp:ident, $p:path, $vec:path, $doc:expr) => {
-        /// Provides $modp implementations of ML-KEM 512
         #[doc = $doc]
         pub mod $modp {
             use super::*;
diff --git a/libcrux-ml-kem/src/mlkem768.rs b/libcrux-ml-kem/src/mlkem768.rs
index fb2a84425..0799112ff 100644
--- a/libcrux-ml-kem/src/mlkem768.rs
+++ b/libcrux-ml-kem/src/mlkem768.rs
@@ -61,7 +61,6 @@ pub type MlKem768KeyPairUnpacked<Vector: VectorType> = MlKemKeyPairUnpacked<RANK
 // Instantiate the different functions.
 macro_rules! instantiate {
     ($modp:ident, $p:path, $vec:path, $doc:expr) => {
-        /// Provides $modp implementations of ML-KEM 768
         #[doc = $doc]
         pub mod $modp {
             use super::*;
diff --git a/libcrux-ml-kem/src/types.rs b/libcrux-ml-kem/src/types.rs
index 91c137fce..a10e04d87 100644
--- a/libcrux-ml-kem/src/types.rs
+++ b/libcrux-ml-kem/src/types.rs
@@ -196,7 +196,7 @@ pub mod unpacked {
     use crate::{polynomial::PolynomialRingElement, vector::traits::Operations};
 
     /// An unpacked ML-KEM IND-CPA Private Key
-    pub struct IndCpaPrivateKeyUnpacked<const K: usize, Vector: Operations> {
+    pub(crate) struct IndCpaPrivateKeyUnpacked<const K: usize, Vector: Operations> {
         pub(crate) secret_as_ntt: [PolynomialRingElement<Vector>; K],
     }
 
@@ -207,7 +207,7 @@ pub mod unpacked {
     }
 
     /// An unpacked ML-KEM IND-CPA Private Key
-    pub struct IndCpaPublicKeyUnpacked<const K: usize, Vector: Operations> {
+    pub(crate) struct IndCpaPublicKeyUnpacked<const K: usize, Vector: Operations> {
         pub(crate) t_as_ntt: [PolynomialRingElement<Vector>; K],
         pub(crate) seed_for_A: [u8; 32],
         pub(crate) A: [[PolynomialRingElement<Vector>; K]; K],