Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fee has been charged twice. #180

Open
bubble501 opened this issue Apr 22, 2018 · 0 comments
Open

fee has been charged twice. #180

bubble501 opened this issue Apr 22, 2018 · 0 comments

Comments

@bubble501
Copy link

In the trade method of Arbitrator, it seems like the fee has been charged twice
$buyPrice = $source->addFeeToPrice( $tradeAmount * $bestBuyRate, $tradeable, $currency );
$boughtAmount = $source->deductFeeFromAmountBuy( $tradeAmount, $tradeable, $currency );
for example, I buy ETH/BTC with rate 0.01, amount 100 and fee rate 0.001, I will pay 1.001BTC to get 99.9 ETH according the code.

but in practice , i wil only pay 1 BTC for 99.9ETH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant