Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate UI for multisig registrations for Jades #2367

Open
moneymanolis opened this issue Aug 18, 2023 · 1 comment · May be fixed by #2370
Open

Create separate UI for multisig registrations for Jades #2367

moneymanolis opened this issue Aug 18, 2023 · 1 comment · May be fixed by #2370
Labels
bug Something isn't working good first issue Good for newcomers hw_jade UIUX

Comments

@moneymanolis
Copy link
Collaborator

moneymanolis commented Aug 18, 2023

More background

The current implementation of automatically registering the multisig in the sign_tx function for Jades creates problems for multisig wallets using multi() descriptors as we can't pass the wallet descriptor type down to the HWI command without changing the HWI lib implementation. It would be better to create a UI for registering the multisig in a place where we have access to the wallet descriptor and then just check when signing whether we have a matching multisig config. BTW, if there is no multisig config, change output is just treated as another output (as expected).

Solution Ideas

In any case: Remove the code to automatically register a multisig when signing with Jades via USB.

Then:
a) Enable the existing Export wallet to device functionality for Jades.
b) Another option: Add another button on the device screen for Jades (if they are used in a multisig) to "Register Multisig Configuration" below and r

@moneymanolis moneymanolis added bug Something isn't working UIUX hw_jade good first issue Good for newcomers labels Aug 18, 2023
@k9ert
Copy link
Collaborator

k9ert commented Aug 25, 2023

I think, the UI part for that is called "export to device", here:
https://github.com/cryptoadvance/specter-desktop/blob/master/src/cryptoadvance/specter/templates/wallet/settings/wallet_settings.jinja#L84-L122

Unfortunately, hwi-devices don't support that at all.

But could still be implemented directly in jade. In the specter this implementes like this.

@moneymanolis moneymanolis linked a pull request Aug 25, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hw_jade UIUX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants