Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: x/supply is not marked as deprecated #720

Closed
2 tasks done
devashishdxt opened this issue Mar 7, 2022 · 2 comments · Fixed by #724
Closed
2 tasks done

Problem: x/supply is not marked as deprecated #720

devashishdxt opened this issue Mar 7, 2022 · 2 comments · Fixed by #724
Assignees
@devashishdxt

Comments

@devashishdxt
Copy link
Collaborator

devashishdxt commented Mar 7, 2022 •
edited
Loading

As discussed in #716, we can deprecate x/supply module and eventually remove it when an alternate way to query liquid supply is available (either via cosmos-sdk's native module or chain-indexer).

Ref: protocolbuffers/protobuf#1734 (comment)
@devashishdxt devashishdxt self-assigned this Mar 7, 2022
@devashishdxt devashishdxt mentioned this issue Mar 7, 2022
Closed
@tomtau
Copy link
Contributor

tomtau commented Mar 7, 2022

and add an entry to https://github.com/crypto-org-chain/chain-main/tree/master/doc/architecture for the decision?

@devashishdxt
Copy link
Collaborator Author

and add an entry to https://github.com/crypto-org-chain/chain-main/tree/master/doc/architecture for the decision?

Sure. I'll create an ADR and add an entry there.

devashishdxt added a commit to devashishdxt/chain-main that referenced this issue Mar 10, 2022
@devashishdxt
Problem: x/supply is not marked as deprecated
af8b469 
Solution: Marked `x/supply` grpc and cli as deprecated. Fixes crypto-org-chain#720.
@devashishdxt devashishdxt mentioned this issue Mar 10, 2022
Merged
devashishdxt added a commit that referenced this issue Mar 10, 2022
@devashishdxt
Problem: x/supply is not marked as deprecated (#724)
a7f75b6 
Solution: Marked `x/supply` grpc and cli as deprecated. Fixes #720.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devashishdxt devashishdxt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: x/supply is not marked as deprecated devashishdxt/chain-main
2 participants
@tomtau @devashishdxt