Manifest author Field Wrongly Typed

[Malix-Labs]

Build tool

Vite

Describe the bug

chrome-extension-tools/packages/vite-plugin/src/node/manifest.ts

Line 43 in 20faa15

author?: string | undefined

typing doesn't match its documentation

Severity

annoyance

[JoeyDoey]

Big CRX fan! Came to post the same. Maybe CRX can inherit from @types/chrome and union/extend those types to include the Firefox and additional fields? That way types stay up to date/accurate.

Author field @types/chrome

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/chrome/index.d.ts#L7398-L7400

 author?: {
            email: string;
        } | undefined;

Author field CRX

https://github.com/crxjs/chrome-extension-tools/blob/main/packages/vite-plugin/src/node/manifest.ts#L43

author?: string | undefined

[hchangjae]

Any updates yet?

[Malix-Labs]

Well I guess I will file a pull request today then

[Malix-Labs]

Update:
This was valid in Manifest V2: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/author

[Malix-Labs]

@JoeyDoey:

Maybe CRX can inherit from @types/chrome and union/extend those types to include the Firefox and additional fields? That way types stay up to date/accurate.

Yes, that would be the best thing to do

I have opened a feature request about it, see #903