Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse host domain in config #3

Open
robertvanhoesel opened this issue May 21, 2020 · 0 comments
Open

Parse host domain in config #3

robertvanhoesel opened this issue May 21, 2020 · 0 comments

Comments

@robertvanhoesel
Copy link
Member

When initializing the SDK with a url that ends with a slash, the SDK won't accept incoming events, as postMessage only contain the origin (scheme + host + port) and not a full url. We do a exact match on the domain set in the config.

new Crowded({
    domain: "https://yourcommmunity.com/" // hostname of the community
                                       ^ will not work
});

We should change this, let domain always be just a domain (without scheme or path segments), prepend it with the scheme ourselves (should always be https) and maybe sanitize the input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant