Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

[Feature Request] Badges before username #73

Open
DevilzAvacado opened this issue Oct 26, 2019 · 4 comments
Open

[Feature Request] Badges before username #73

DevilzAvacado opened this issue Oct 26, 2019 · 4 comments

Comments

@DevilzAvacado
Copy link

Like the title says. It would be nice to have a feature like this that can be toggled on and off. In my opinion it would fit well with the hide viewer avatar feature that is already in the extension, as there is still a gap where the avatars use to be when that is enabled.

@ebiggz
Copy link
Member

ebiggz commented Oct 26, 2019

Hi @DevilzAvacado, thanks for the suggestion. This is something we could potentially look into.

I want to verify something though. What "gap" are you referring to when avatars are disabled? There should only be a small amount of padding between the edge and the username like so:
image

@DevilzAvacado
Copy link
Author

Hi @DevilzAvacado, thanks for the suggestion. This is something we could potentially look into.

I want to verify something though. What "gap" are you referring to when avatars are disabled? There should only be a small amount of padding between the edge and the username like so:
image

My mistake. i forgot the refresh my browser after disabling the viewer avatars.

@Y0dax
Copy link

Y0dax commented Oct 28, 2019

I am experiencing the same problem as @DevilzAvacado. Even after refreshing, clearing cache, and restarting browser. The avatars are removed, but the spacing remains as if the avatar was there.

Perhaps explicitly removing the left margin would do the trick?

       ${options.hideChatAvatars ? `               
        b-chat-client-host-component div div[class^="messageContent"] {
            margin-left: 0;
        }
        ` : ''}

@ebiggz
Copy link
Member

ebiggz commented Oct 28, 2019

@DevilzAvacado @Y0dax I was finally able to replicate the issue. It is resetting the margin, however, it was only doing it if you had the "Custom Font Size" option also enabled, which is definitely a bug. I've resolved this bug and just pushed update v2.4.2 with the fix to the Chrome and Firefox stores - it should be available in your browser shortly.

I created a separate issue for this bug (#74) and will leave this open for the original feature request.

Thanks for the report, both for the original feature request and for helping us discover a bug :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants