Add reference fields to the InitProvider #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergen Yalçın <[email protected]>
ulucinar
reviewed
Dec 25, 2023
Comment on lines
+438
to
+444
| if isInit { | ||
| r.initTags = append(r.initTags, refTags...) | ||
| r.initFields = append(r.initFields, refFields...) | ||
| } else { | ||
| r.paramTags = append(r.paramTags, refTags...) | ||
| r.paramFields = append(r.paramFields, refFields...) | ||
| } |
There was a problem hiding this comment.
I think the reference fields will now always be added to the spec.forProvider and spec.initProvider, is this correct? If we don't have the branching here, what would cause an issue is the fact that this function is called once for the forProvider and once for initProvider, is this correct?
There was a problem hiding this comment.
Yes the both are correct. Now we always generate the reference fields for both. And if we do not have a branch here, this will cause an issue.
Signed-off-by: Sergen Yalçın <[email protected]>
ulucinar
approved these changes
Dec 26, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #307
This PR supports generation of reference fields and reference resolver functions to the InitProvider.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
This PR tested against to the upjet-based provider-aws