Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-1.1] Add a new configuration option for required field generation #382

Merged

Conversation

sergenyalcin
Copy link
Member

Description

Backport of #381 to release-1.1.

Signed-off-by: Sergen Yalçın <[email protected]>
(cherry picked from commit bdfbe67)
…iredFields

- Deprecate config.MarkAsRequired in favor of a new configuration function on *config.Resource that still accepts a slice to mark multiple fields as required without doing and invervention in native field schema.

Signed-off-by: Sergen Yalçın <[email protected]>
(cherry picked from commit f25329f)
Signed-off-by: Sergen Yalçın <[email protected]>
(cherry picked from commit b73a85f)
@sergenyalcin sergenyalcin requested a review from ulucinar as a code owner March 19, 2024 10:04
@sergenyalcin sergenyalcin changed the title Backport 381 to release 1.1 [Backport release-1.1] Add a new configuration option for required field generation Mar 19, 2024
Signed-off-by: Sergen Yalçın <[email protected]>
(cherry picked from commit 845dbf6)
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sergenyalcin, lgtm. Changes already reviewed in #381.

Could you please have #381 also backported to the release-1.2 branch?

@sergenyalcin
Copy link
Member Author

#383 Backport PR to rel-1.2 was opened.

@sergenyalcin sergenyalcin merged commit e744bf2 into crossplane:release-1.1 Mar 19, 2024
7 checks passed
@sergenyalcin sergenyalcin deleted the backport-381-to-release-1.1 branch March 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants