Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore cidr_block on lateinitialize to avoid conflicts when using ipam #883

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

djeremiah
Copy link
Collaborator

Description of your changes

When configuring a VPC with an IPAM pool and a netmask length, the ipv4 cidr block must not be late initialized.
Fixes #879

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Local testing
uptest e2e examples/ec2/vpc-ipampool.yaml

@djeremiah
Copy link
Collaborator Author

/test-examples="examples/ec2/vpc-ipampool.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @djeremiah, LGTM.

@turkenf turkenf merged commit b815340 into crossplane-contrib:main Sep 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPC resource cannot refresh state when created with IPAM pool
2 participants