Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use custom launchtemplate with EKS nodegroup #866

Closed
recht opened this issue Sep 6, 2023 · 5 comments
Closed

Unable to use custom launchtemplate with EKS nodegroup #866

recht opened this issue Sep 6, 2023 · 5 comments

Comments

@recht
Copy link

recht commented Sep 6, 2023

What happened?

When trying to use a custom launchtemplate for an EKS nodegroup the provider fails with apply failed: creating EKS Node Group (XXXX): InvalidParameterException: Disk size must be specified within the launch template.

This seems to be because even if diskSize is not set on the nodegroup, it will set a default value, but when using a launchtemplate, that value should not be set at all.

How can we reproduce it?

Set a launchtemplate in a nodegroup resource.

What environment did it happen in?

  • Crossplane Version: 1.13.2
  • Provider Version: 0.38.0
@recht recht added bug Something isn't working needs:triage labels Sep 6, 2023
@turkenf
Copy link
Collaborator

turkenf commented Oct 9, 2023

@recht, please share with us the example MR you used, the steps to create the issue, the expected behavior, and the actual behavior.

Copy link

github-actions bot commented Apr 2, 2024

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@nelloserio
Copy link

When you specify a LaunchTemplate, you have to remove "diskSize" attribute when you define the NodeGroup. Otherwise, the deployment will fail as stated here:
https://docs.aws.amazon.com/eks/latest/APIReference/API_CreateNodegroup.html

@turkenf turkenf removed the community label May 11, 2024
Copy link

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Aug 17, 2024
Copy link

github-actions bot commented Sep 3, 2024

This issue is being closed since there has been no activity for 14 days since marking it as stale. If you still need help, feel free to comment or reopen the issue!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants