Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqs): update loop queues.sqs #1356

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Jun 12, 2024

Description of your changes

We've observed update loops with the Queue.sqs resources when inline policies are given.
The desired policy document in the spec can differ from the actual (observed) document

like:

{
	"Statement":[
		{
			"Sid":"example",
			"Effect":"Allow",
			"Principal":{
				"Service":"s3.amazonaws.com"
			},
			"Action":"sqs:SendMessage",
			"Resource":"arn:aws:sqs:us-west-1:*:queue-policy"
		}
	]
}
{
	"Statement":[
		{
			"Action":"sqs:SendMessage",
			"Effect":"Allow",
			"Principal":{
				"Service":"s3.amazonaws.com"
			},
			"Resource":"arn:aws:sqs:us-west-1:*:queue-policy",
			"Sid":"example"
		}
	],
	"Version":"2008-10-17"
}

so i used the custom diff which we implemented here also: #1347

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Signed-off-by: Christopher Haar <[email protected]>
@haarchri
Copy link
Member Author

can someone start uptest? ;) examples/sqs/v1beta1/queue-with-policy.yaml

@ulucinar
Copy link
Collaborator

/test-examples="examples/sqs/v1beta1/queue-with-policy.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jun 12, 2024

can someone start uptest? ;) examples/sqs/v1beta1/queue-with-policy.yaml

You should be able to trigger it too, @haarchri :)

@turkenf
Copy link
Collaborator

turkenf commented Jun 13, 2024

/test-examples="examples/sns/v1beta1/topic-with-policy.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haarchri, LGTM.

@turkenf turkenf merged commit 79765e3 into crossplane-contrib:main Jun 13, 2024
13 checks passed
Copy link

Successfully created backport PR #1361 for release-1.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants