Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run uptest Update tests for most resources #1151

Open
mbbush opened this issue Feb 14, 2024 · 6 comments
Open

Run uptest Update tests for most resources #1151

mbbush opened this issue Feb 14, 2024 · 6 comments
Labels
enhancement New feature or request needs:triage

Comments

@mbbush
Copy link
Collaborator

mbbush commented Feb 14, 2024

What problem are you facing?

From time to time, we encounter bugs in provider-aws that are not caught by our e2e test suite, uptest, because they only occur when a resource is being updated.

For some of these bugs, only a particular, resource-specific type of update triggers these bugs. To effectively write a test for them requires domain-specific knowledge related to the resource. The only solution I can think of for improvement here is to provide better documentation and examples of how to test updates using uptest.

For other bugs, any update at all will work. Given that many/most aws resources have a spec.forProvider.tags field, which can contain arbitrary data, this seems like a "better than nothing" good starting place, to validate that in addition to creating, importing, and deleting a resource, provider-aws can also update the resource's tags.

How could Official AWS Provider help solve your problem?

For all resources which have a spec.forProvider.tags field, make a change to it during the Update step of uptest, rather than skipping the Update step.

@mbbush mbbush added enhancement New feature or request needs:triage labels Feb 14, 2024
Copy link

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label May 15, 2024
@pierluigilenoci
Copy link

/fresh

@github-actions github-actions bot removed the stale label May 18, 2024
Copy link

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Aug 16, 2024
@pierluigilenoci
Copy link

/fresh

@github-actions github-actions bot removed the stale label Aug 23, 2024
Copy link

This provider repo does not have enough maintainers to address every issue. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions bot added the stale label Nov 21, 2024
@pierluigilenoci
Copy link

/fresh

@github-actions github-actions bot removed the stale label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs:triage
Projects
None yet
Development

No branches or pull requests

2 participants