Subnet creation causes conflict

[mjnovice]

What happened?

I created a subnet MR in a VPC. The external resource got created, but the MR showed a conflict error.

➜  cloudgen-operator git:(mj/go-aws-cp)  k logs -n upbound-system                      provider-aws-ec2-f90d25cd37c7-668bbf4896-7j6zd   | grep 1zkb4j
2023-12-24T17:14:19Z	DEBUG	provider-aws	Reconciling	{"controller": "managed/ec2.aws.upbound.io/v1beta1, kind=subnet", "request": {"name":"ci-aseks4858980-public-subnet-1zkb4j"}}
2023-12-24T17:14:19Z	DEBUG	provider-aws	Connecting to the service provider	{"uid": "a7a02680-c4b1-4318-be08-717fed648301", "name": "ci-aseks4858980-public-subnet-1zkb4j", "gvk": "ec2.aws.upbound.io/v1beta1, Kind=Subnet"}
2023-12-24T17:14:19Z	DEBUG	provider-aws	Instance state not found in cache, reconstructing...	{"uid": "a7a02680-c4b1-4318-be08-717fed648301", "name": "ci-aseks4858980-public-subnet-1zkb4j", "gvk": "ec2.aws.upbound.io/v1beta1, Kind=Subnet"}
2023-12-24T17:14:19Z	DEBUG	provider-aws	Observing the external resource	{"uid": "a7a02680-c4b1-4318-be08-717fed648301", "name": "ci-aseks4858980-public-subnet-1zkb4j", "gvk": "ec2.aws.upbound.io/v1beta1, Kind=Subnet"}
2023-12-24T17:14:19Z	DEBUG	provider-aws	Diff detected	{"uid": "a7a02680-c4b1-4318-be08-717fed648301", "name": "ci-aseks4858980-public-subnet-1zkb4j", "gvk": "ec2.aws.upbound.io/v1beta1, Kind=Subnet", "instanceDiff": "*terraform.InstanceDiff{mu:sync.Mutex{state:0, sema:0x0}, Attributes:map[string]*terraform.ResourceAttrDiff{\"arn\":*terraform.ResourceAttrDiff{Old:\"\", New:\"\", NewComputed:true, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"assign_ipv6_address_on_creation\":*terraform.ResourceAttrDiff{Old:\"\", New:\"false\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"availability_zone\":*terraform.ResourceAttrDiff{Old:\"\", New:\"us-east-1a\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:true, Sensitive:false, Type:0x0}, \"availability_zone_id\":*terraform.ResourceAttrDiff{Old:\"\", New:\"\", NewComputed:true, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:true, Sensitive:false, Type:0x0}, \"cidr_block\":*terraform.ResourceAttrDiff{Old:\"\", New:\"173.10.0.0/18\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:true, Sensitive:false, Type:0x0}, \"enable_dns64\":*terraform.ResourceAttrDiff{Old:\"\", New:\"false\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"enable_resource_name_dns_a_record_on_launch\":*terraform.ResourceAttrDiff{Old:\"\", New:\"false\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"enable_resource_name_dns_aaaa_record_on_launch\":*terraform.ResourceAttrDiff{Old:\"\", New:\"false\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"ipv6_cidr_block_association_id\":*terraform.ResourceAttrDiff{Old:\"\", New:\"\", NewComputed:true, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"ipv6_native\":*terraform.ResourceAttrDiff{Old:\"\", New:\"false\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:true, Sensitive:false, Type:0x0}, \"map_public_ip_on_launch\":*terraform.ResourceAttrDiff{Old:\"\", New:\"true\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"owner_id\":*terraform.ResourceAttrDiff{Old:\"\", New:\"\", NewComputed:true, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"private_dns_hostname_type_on_launch\":*terraform.ResourceAttrDiff{Old:\"\", New:\"\", NewComputed:true, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.%\":*terraform.ResourceAttrDiff{Old:\"0\", New:\"12\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.MgmtPlane\":*terraform.ResourceAttrDiff{Old:\"\", New:\"cloudgen-dev-mgmt\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.Name\":*terraform.ResourceAttrDiff{Old:\"\", New:\"ci-aseks4858980-public-subnet-1\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.Owner\":*terraform.ResourceAttrDiff{Old:\"\", New:\"[email protected]\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.Project\":*terraform.ResourceAttrDiff{Old:\"\", New:\"Service Fabric\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.ProvisionedBy\":*terraform.ResourceAttrDiff{Old:\"\", New:\"crossplane-operator\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.clusterId\":*terraform.ResourceAttrDiff{Old:\"\", New:\"ci-aseks4858980\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.clusterName\":*terraform.ResourceAttrDiff{Old:\"\", New:\"aseks4858980\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.crossplane-kind\":*terraform.ResourceAttrDiff{Old:\"\", New:\"subnet.ec2.aws.upbound.io\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.crossplane-name\":*terraform.ResourceAttrDiff{Old:\"\", New:\"ci-aseks4858980-public-subnet-1zkb4j\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.crossplane-providerconfig\":*terraform.ResourceAttrDiff{Old:\"\", New:\"service-fabric\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.kubernetes.io/cluster/ci-aseks4858980\":*terraform.ResourceAttrDiff{Old:\"\", New:\"shared\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags.kubernetes.io/role/elb\":*terraform.ResourceAttrDiff{Old:\"\", New:\"1\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.%\":*terraform.ResourceAttrDiff{Old:\"0\", New:\"12\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.MgmtPlane\":*terraform.ResourceAttrDiff{Old:\"\", New:\"cloudgen-dev-mgmt\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.Name\":*terraform.ResourceAttrDiff{Old:\"\", New:\"ci-aseks4858980-public-subnet-1\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.Owner\":*terraform.ResourceAttrDiff{Old:\"\", New:\"[email protected]\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.Project\":*terraform.ResourceAttrDiff{Old:\"\", New:\"Service Fabric\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.ProvisionedBy\":*terraform.ResourceAttrDiff{Old:\"\", New:\"crossplane-operator\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.clusterId\":*terraform.ResourceAttrDiff{Old:\"\", New:\"ci-aseks4858980\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.clusterName\":*terraform.ResourceAttrDiff{Old:\"\", New:\"aseks4858980\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.crossplane-kind\":*terraform.ResourceAttrDiff{Old:\"\", New:\"subnet.ec2.aws.upbound.io\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.crossplane-name\":*terraform.ResourceAttrDiff{Old:\"\", New:\"ci-aseks4858980-public-subnet-1zkb4j\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.crossplane-providerconfig\":*terraform.ResourceAttrDiff{Old:\"\", New:\"service-fabric\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.kubernetes.io/cluster/ci-aseks4858980\":*terraform.ResourceAttrDiff{Old:\"\", New:\"shared\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"tags_all.kubernetes.io/role/elb\":*terraform.ResourceAttrDiff{Old:\"\", New:\"1\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}, \"vpc_id\":*terraform.ResourceAttrDiff{Old:\"\", New:\"vpc-0e49f678f92bddb40\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:true, Sensitive:false, Type:0x0}}, Destroy:false, DestroyDeposed:false, DestroyTainted:false, RawConfig:cty.NilVal, RawState:cty.NilVal, RawPlan:cty.NilVal, Meta:map[string]interface {}(nil)}"}
2023-12-24T17:14:19Z	DEBUG	provider-aws	Async create starting...	{"trackerUID": "a7a02680-c4b1-4318-be08-717fed648301", "resourceName": "ci-aseks4858980-public-subnet-1zkb4j", "tfID": ""}
2023-12-24T17:14:19Z	DEBUG	provider-aws	Creating the external resource	{"uid": "a7a02680-c4b1-4318-be08-717fed648301", "name": "ci-aseks4858980-public-subnet-1zkb4j", "gvk": "ec2.aws.upbound.io/v1beta1, Kind=Subnet"}
          Value: "ci-aseks4858980-public-subnet-1zkb4j"
2023-12-24T17:14:19Z	DEBUG	provider-aws	Successfully requested creation of external resource	{"controller": "managed/ec2.aws.upbound.io/v1beta1, kind=subnet", "request": {"name":"ci-aseks4858980-public-subnet-1zkb4j"}, "uid": "a7a02680-c4b1-4318-be08-717fed648301", "version": "547921353", "external-name": "", "external-name": ""}
2023-12-24T17:14:19Z	DEBUG	provider-aws	Calling the inner handler for Update event.	{"gvk": "ec2.aws.upbound.io/v1beta1, Kind=Subnet", "name": "ci-aseks4858980-public-subnet-1zkb4j", "queueLength": 0}
2023-12-24T17:14:19Z	DEBUG	events	Successfully requested creation of external resource	{"type": "Normal", "object": {"kind":"Subnet","name":"ci-aseks4858980-public-subnet-1zkb4j","uid":"a7a02680-c4b1-4318-be08-717fed648301","apiVersion":"ec2.aws.upbound.io/v1beta1","resourceVersion":"547923661"}, "reason": "CreatedExternalResource"}
2023-12-24T17:14:19Z	DEBUG	provider-aws	Reconciling	{"controller": "managed/ec2.aws.upbound.io/v1beta1, kind=subnet", "request": {"name":"ci-aseks4858980-public-subnet-1zkb4j"}}
2023-12-24T17:14:19Z	DEBUG	provider-aws	Connecting to the service provider	{"uid": "a7a02680-c4b1-4318-be08-717fed648301", "name": "ci-aseks4858980-public-subnet-1zkb4j", "gvk": "ec2.aws.upbound.io/v1beta1, Kind=Subnet"}
2023-12-24T17:14:19Z	DEBUG	provider-aws	Async create ended.	{"trackerUID": "a7a02680-c4b1-4318-be08-717fed648301", "resourceName": "ci-aseks4858980-public-subnet-1zkb4j", "error": "async create failed: failed to create the resource: [{0 creating EC2 Subnet: InvalidSubnet.Conflict: The CIDR '173.10.0.0/18' conflicts with another subnet\n\tstatus code: 400, request id: b5b08d61-b96a-4069-aee2-4ef0655ca335  []}]", "tfID": ""}
2023-12-24T17:14:19Z	DEBUG	provider-aws	Reconcile request has been requeued.	{"gvk": "ec2.aws.upbound.io/v1beta1, Kind=Subnet", "name": "ci-aseks4858980-public-subnet-1zkb4j", "rateLimiterName": "asyncCallback", "when": "16m40s"}

How can we reproduce it?

Try creating a subnet MR in a VPC repeatedly.

What environment did it happen in?

• Crossplane Version: v1.14.5-up.1
• Provider Version: 0.45.0
• Kubernetes Version: 1.25
• Kubernetes Distribution: kind

[mjnovice]

Possibly related to crossplane/upjet#305 ? cc - @ulucinar

[turkenf]

@mjnovice, thanks for bringing this up. Could you please try it on version 0.47.1 of the provider and let us know?

[mjnovice]

Don't see it thus far on the updated version v1.2.0. Will close it.