From 65e9b47d4004508dadb0d5ca62f97926b61ff57d Mon Sep 17 00:00:00 2001
From: Erhan Cagirici <erhan@upbound.io>
Date: Fri, 18 Oct 2024 14:19:04 +0300
Subject: [PATCH] add custom diff for LBListener forward options

Signed-off-by: Erhan Cagirici <erhan@upbound.io>
---
 config/elbv2/config.go | 67 +++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 66 insertions(+), 1 deletion(-)

diff --git a/config/elbv2/config.go b/config/elbv2/config.go
index 4bbcde047f..b5d7dcba3d 100644
--- a/config/elbv2/config.go
+++ b/config/elbv2/config.go
@@ -4,7 +4,14 @@
 
 package elbv2
 
-import "github.com/crossplane/upjet/pkg/config"
+import (
+	"regexp"
+	"strings"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/terraform"
+
+	"github.com/crossplane/upjet/pkg/config"
+)
 
 // Configure adds configurations for the elbv2 group.
 func Configure(p *config.Provider) {
@@ -44,6 +51,64 @@ func Configure(p *config.Provider) {
 				TerraformName: "aws_lb_target_group",
 			},
 		}
+
+		// lb_listener schema allows to configure "default_action" with type
+		// "forward", in 2 different ways.
+		// 1. you can specify, default_action.0.forward, which allows configuring
+		//    multiple target groups.
+		// 2. you can specify default_action.0.target_group_arn if you want
+		//    to configure only one target group.
+		// Former is a more general way, and latter is more of a shortcut for
+		// a specific case, which can already be expressed with #1.
+		// TF implementation instructs to specify either #1 or #2, not both.
+		// However, they both end up in the state redundantly and cause
+		// unnecessary diff.
+		r.TerraformCustomDiff = func(diff *terraform.InstanceDiff, _ *terraform.InstanceState, _ *terraform.ResourceConfig) (*terraform.InstanceDiff, error) {
+			// skip no diff or destroy diffs
+			if diff == nil || diff.Empty() || diff.Destroy || diff.Attributes == nil {
+				return diff, nil
+			}
+			duplicatedAction := ""
+			for k, attrDiff := range diff.Attributes {
+				// user specified the "default_action.0.target_group_arn" and
+				// "default_action.0.forward" is not specified in config.
+				// In that case, default_action.0.forward is populated
+				// by the AWS API, which can cause an unnecessary diff,
+				// trying to remove that "auto-populated" element.
+				if regexp.MustCompile(`^default_action\.\d+\.forward\.#$`).MatchString(k) &&
+					attrDiff.New == "0" && attrDiff.Old == "1" {
+					delete(diff.Attributes, k)
+					// save this attribute path to remove remaining diffs
+					// of its nested fields if any in a second pass
+					duplicatedAction = strings.TrimSuffix(k, ".#")
+				}
+				// this is the same case as above
+				if regexp.MustCompile(`^default_action\.\d+\.forward\.\d+\.target_group\.#$`).MatchString(k) &&
+					attrDiff.New == "0" && attrDiff.Old == "1" {
+					delete(diff.Attributes, k)
+				}
+				// this is the same case but vice versa. user specified
+				// forward target via default_action.0.forward, and
+				// default_action.0.target_group_arn is omitted.
+				// In that case, default_action.0.target_group_arn is populated
+				// by the AWS API and ends up in the state, causing
+				// an unnecessary diff, which we omit here.
+				if regexp.MustCompile(`^default_action\.\d+\.target_group_arn$`).MatchString(k) &&
+					attrDiff.New == "" && attrDiff.Old != "" && attrDiff.NewRemoved {
+					delete(diff.Attributes, k)
+				}
+			}
+			// if we have caught an unnecessary diff for default_action.0.forward, remove
+			// any sub-element diffs of it.
+			if duplicatedAction != "" {
+				for k := range diff.Attributes {
+					if strings.HasPrefix(k, duplicatedAction) {
+						delete(diff.Attributes, k)
+					}
+				}
+			}
+			return diff, nil
+		}
 	})
 
 	p.AddResourceConfigurator("aws_lb_target_group", func(r *config.Resource) {