Add new flag '--reconciliation-timeout' #218
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This pull request introduces a new reconciliationTimeout flag to the Crossplane project. This feature allows users to specify a timeout duration for the reconciliation process, addressing the issue of indefinite waits during resource reconciliation. This enhancement ensures that the reconciliation function completes within a defined timeframe, improving reliability and efficiency in resource management. The timeout is cumulative for all calls within a single reconciliation cycle, allowing necessary operations such as error reporting and status updates to be completed before the timeout is enforced.
Fixes #217
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
I built the provider and deployed it locally using the following configuration:
I tested the feature with an application using the Helmfile plugin, where Helmfile rendering typically takes more than 1 minute. With the default reconciliation timeout set to 60 seconds, longer rendering processes would fail. By setting the reconciliation timeout to more than 60 seconds, I was able to successfully create an application with manifest generation taking over a minute, without encountering any errors.
Helmfile example: