Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge options #75

Closed
christopherparo opened this issue Jan 5, 2024 · 2 comments
Closed

Merge options #75

christopherparo opened this issue Jan 5, 2024 · 2 comments

Comments

@christopherparo
Copy link

Are there plans to add support for this similar to what is in the original p/t feature?

https://docs.crossplane.io/latest/concepts/patch-and-transform/#merge-options

Apologies if this is already supported and I missed it somewhere.

@negz
Copy link
Member

negz commented Jan 8, 2024

I'm hoping we can avoid it.

Functions use server side apply (SSA) to apply their desired state. SSA is supposed to be able to handle merging arrays and objects correctly. The only catch is that the merge strategy needs to be configured for each type of custom resource (e.g. for each Crossplane MR) at the schema level. We've made some progress toward that per crossplane/upjet#300.

@christopherparo
Copy link
Author

Oh this is perfect! Thank you. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants