Fix /home/application being "write for all" (SSH login not working anymore) #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default "git context" will garble the file permissions. Apparently there is a "umask 000" (all files get 666/777 permissions). This affects the "COPY /files/ssh/ /"
Make sure the copied files have the correct permissions regardless on how docker copies them with "COPY" (so it does not depend on local environmental circumstances).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "docker build" in "git context" used by the Github Actions seem to work differently now, using an "umask 000", so that all files which are being
COPYin theDockerfilewill get a "666/777" permissions. And thus the SSH login won't work anymore:We fix that in two ways:
actions/checkout@v3action which we are doing anyway before itCOPYinstructions