You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The recv_ functions generated by the apache thrift code generator adds delete this._reqs[rseqid]; to clean it up. thrift-typescript does not, so it leaks memory -- potentially a lot especially for framed transport due to its use of buffer.slice() internally.
Possibly this ought to be fixed on the apache thrift library side (poor separation between the connection and client class code) but figured the discrepancy/leak should be noted here since this library tries to provide a mostly-compatible code generation of the thrift client classes.
The text was updated successfully, but these errors were encountered:
Noticed a memory leak when trying to use the
thrift-typescript
generated classes (--target apache
with the apachethrift
library's thrift client. The issue is https://github.com/apache/thrift/blob/234e80e1b9acb1bc778c7adfaa6cb695d922d5f0/lib/nodejs/lib/thrift/connection.js#L125 which injects an entry (with a negative sequence number) in_reqs
for each request.The
recv_
functions generated by the apache thrift code generator addsdelete this._reqs[rseqid];
to clean it up.thrift-typescript
does not, so it leaks memory -- potentially a lot especially for framed transport due to its use ofbuffer.slice()
internally.Possibly this ought to be fixed on the apache
thrift
library side (poor separation between the connection and client class code) but figured the discrepancy/leak should be noted here since this library tries to provide a mostly-compatible code generation of the thrift client classes.The text was updated successfully, but these errors were encountered: