Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more extensive tests #59

Closed
cfergeau opened this issue Aug 23, 2023 · 1 comment
Closed

Add more extensive tests #59

cfergeau opened this issue Aug 23, 2023 · 1 comment

Comments

@cfergeau
Copy link
Collaborator

vfkit has some unit tests, but there are no tests starting a VM and checking the VM has the expected devices.
https://github.com/Code-Hex/vz makes use of https://github.com/Code-Hex/puipui-linux to start a very small VM and get a shell into the VM. vfkit could reuse this to implement various tests (check lspci output, test file sharing, test vsock listen and connect, ...) to catch regressions early.
https://github.com/cfergeau/vfkit/tree/puipui/ has code which downloads puipui, starts a VM and shuts it down through ssh.
We can build on that to add more useful tests.

@cfergeau
Copy link
Collaborator Author

This was done in #61
The tests for VM devices could be made even more extensive, but these will be good enough for now, let's close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant