Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded Directories and File Names, Not Scalable #3

Open
schackartk opened this issue Apr 19, 2021 · 0 comments
Open

Hard-coded Directories and File Names, Not Scalable #3

schackartk opened this issue Apr 19, 2021 · 0 comments

Comments

@schackartk
Copy link

It seems that the code must be edited in several ways for it to function:

  • Firstly, the directory where the .csv files are must be set so that the command os.chdir('dir') doesn't result in the error No such file or directory: 'dir'.
  • Next, the names of the relevant files must be changed manually (e.g. the training data and target data files).

Users should not have to change source code for it to work. I would suggest utilizing arguments, so that the necessary paths can be passed to the script when it is run. argparse is great for this purpose.

As it stands, the code cannot be run upon cloning, since there is no 'dir' directory. It also is not scalable because users will likely want to run the classification on many datasets (myself included) and we need to automate the way we call this tool. It is infeasible to edit the code for each new dataset. Keep in mind, we are users of the tool and so should not have to change the tool's code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant