Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for querying files in a commit #12

Open
crawford opened this issue Sep 13, 2017 · 5 comments
Open

Add support for querying files in a commit #12

crawford opened this issue Sep 13, 2017 · 5 comments

Comments

@crawford
Copy link
Owner

Things to consider:

  • Should the full file be exposed?
  • How are diffs represented?
  • Has the file been added or deleted?
@crawford crawford added this to the Initial Release milestone Sep 13, 2017
@arithx
Copy link
Contributor

arithx commented Sep 13, 2017

Should we also expose helper attributes like Net Additions & Removals?

@crawford
Copy link
Owner Author

If diffs are represented as a list of additions and a list of removals, the length operator will make that simple. I'm not sure the best way to represent a diff though.

@arithx
Copy link
Contributor

arithx commented Sep 13, 2017

In support of checks like "vendor operations must be done in seperate commits" it'd be nice to expose even just the filename in an initial implementation while we wait to figure out how to expose things like diffs, etc.

@sdemos
Copy link

sdemos commented Sep 22, 2017

What kinds of behaviors would a diff be useful for? I can't really think of any that seem to fall in the scope of this project. Seems like that is taken care of by the code review part, or any number of other ci/linting tools.

I think it does make sense for lists of added/removed/changed files to be included though, for automated review of vendoring operations. Seems simple enough to just include that in the provided context as lists of each respective operation.

@crawford
Copy link
Owner Author

The idea was to help detect simple changes, for example, if you wanted to make sure that a version string is updated in every location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants