-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay for rate limit #726
Comments
Looks like we never removed I believe individual projects can ask to get the rate limit lifted, so we also likely want to make the rate limit values configurable (including backoff time). That would also allow people to workaround it if our rate limit configuration is stale. We could have a Thoughts? |
I agree that it should be configurable. For large projects, this would be required every time, so a configuration option would make sense, I think. But I'd be happy with a command line option too! |
Even if its required every time, I think I'd still want an opt-in every time so someone doesn't run it without thinking and have to worry about canceling because it'll take 30 minutes and they have to shutdown in 10. This is also making me think that the error mode should have en estimate for how long it would take and the sleep mode should show a warning with that time before the confirmation prompt. |
Hi! If I understand correctly, this tool will abort when trying to upload more crates than crates.io allows. However, I'd love to use this for uutils, where we have a lot of crates (~100) that we publish at the same time. We currently have a big unwieldy bash script to publish the crates, which I'd love to off-load to
cargo-release
. I don't mind waiting for the rate limit ifcargo-release
will continue once it can. I can see various solutions to this:cargo-release
, that is, keep track of when crates were published and figure out when the next crate can be published.However, this should probably also be configurable since there are projects that do not have to adhere to these limits. For the first option, the delay could be some config option.
I'm happy to implement any solution you see fit!
Relevant issues: #483, #584
The text was updated successfully, but these errors were encountered: