Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Loop Conditions #20

Open
fireproofsocks opened this issue Nov 5, 2014 · 0 comments
Open

Detect Loop Conditions #20

fireproofsocks opened this issue Nov 5, 2014 · 0 comments

Comments

@fireproofsocks
Copy link
Member

You create a race condition that triggers a PHP memory error if you do something like use getProductImages to query for and format a list of images, but then the formatting Chunks include more instances of getProductImages.

This is probably too obscure to really merit hacky prevention/protection, but it would be nice for the user/developer if this condition could be detected.

Note this problem is not specific at all to Moxycart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant