-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
won't work if Craft "gqlTypePrefix" config is set. #58
Comments
Interesting, I'll take a look! |
Hi @andris-sevcenko, I would like to help with some code. I am a pretty decente js/ts developer, how can I help? Do you have a process/setup in place that you use to develop and test this plugin? Thanks! |
Ah, shoot, so sorry about forgetting this. There's no setup, really. Just a local Gatsby install that I use and then I throw code at the wall and see what sticks! To work around this issue I'll have to add another config setting to the source plugin to mirror the I'll get to that now, so you can resume your work! |
Okay, just pushed 69a00d7 to fix this and a release should follow today, too! You will also need to update the Gatsby Helper plugin to version 1.0.9. |
Also, in the future, you can just submit PRs without specifically asking permission - I don't have a "smart" build process or anything like that - just make changes, compile to JS and that's it :) All testing currently is done via a "does it build?" test, unfortunately, as we don't have many resources dedicated to this plugin, currently, |
Just tested locally and with In my specific project, I've set |
Spoken too early. All the assets types and interfaces lost gatsby-source-craft/gatsby-node.js Line 408 in 69a00d7
|
Sent pull request #60 |
Description
If you try to set "gqlTypePrefix" to "Craft_" on a working Craft + Gatsby implementation, you get:
The text was updated successfully, but these errors were encountered: