Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Disable missing elements globally” and “Delete missing elements” to factor in feed's siteId #1474

Merged

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Jun 28, 2024

Description

When running an import with “Disable missing elements globally” or “Delete missing elements” checked, get the missing element by ID factoring in the site the feed is for.

Related issues

#1468

@i-just i-just requested a review from angrybrad as a code owner June 28, 2024 10:07
@i-just i-just changed the base branch from 6.x to 5.x June 28, 2024 10:07
@i-just i-just changed the title when disabling globally, get element by id regardless of the site “Disable missing elements globally” and “Delete missing elements” to factor in feed's siteId Jun 28, 2024
@angrybrad angrybrad merged commit a0dfc36 into 5.x Jul 7, 2024
5 checks passed
@angrybrad angrybrad deleted the bugfix/1468-disable-globally-for-non-primary-site-feed branch July 7, 2024 15:57
angrybrad added a commit that referenced this pull request Jul 9, 2024
angrybrad added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants