Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename mapping from parent to parentId #1313

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from
Open

Rename mapping from parent to parentId #1313

wants to merge 1 commit into from

Commits on Oct 25, 2023

  1. Rename mapping from parent to parentId 

    The attribute `parentId` is used in Craft to signify the value of the
parent element, if any.  Therefore, the mapping handle should also be
`parentId`.

This patch changes the mapping handle from `parent` into `parentId`.
This allows the comparison code to properly verify that an existing
parent already exists.  Without this patch the current comparison will
use the `parent` property that does not exist in a Craft entry.  This
should have been `parentId` which does exist.
    @boudewijn-zicht
    boudewijn-zicht committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    e74d28f View commit details
    Browse the repository at this point in the history