Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: Reordering of disabled variants #3769

Open
i-just opened this issue Nov 15, 2024 · 3 comments
Open

[5.x]: Reordering of disabled variants #3769

i-just opened this issue Nov 15, 2024 · 3 comments

Comments

@i-just
Copy link
Contributor

i-just commented Nov 15, 2024

What happened?

We also have a different problem when I move an disabled variant:
Image
And save the page with "ctrl" + "s" the whole layout of variants changes:
Image
In the first image, we initially had two disabled products stacked above each other, with our moved variant positioned below them. However, after saving the page, the arrangement changed. Now, either:

  • Two enabled variants have moved up, or
  • Our moved variant has shifted down, now paired with another disabled variant.

Originally posted by @WHITE-developer in #16103

Craft CMS version

5.5.0.1

Craft Commerce version

5.2.4

PHP version

8.3

Operating system and version

ddev

Database type and version

mysql 8.0

Image driver and version

No response

Installed plugins and versions

Copy link

linear bot commented Nov 15, 2024

@WHITE-developer
Copy link

Some additional info:

Occasionally, variants cannot be moved up to a new position down works fine but up sometimes won't work. In the attached video, you can see the following behavior:

The first variant I moved up successfully retained its new position after saving.
However, when I attempted to move another variant up, it reverted to its original position after saving.

Steps to Reproduce:

  1. Open the variants.
  2. Move one variant to a new position and save.
  3. Move another variant to a different position and save.
  4. Observe whether the second variant retains its position.

Expected Behavior:

  • All moved variants should retain their new positions after saving.

Actual Behavior:

  • While some variants stay in their new positions, others revert to their original positions after saving.

Attachments:

When there is nothing happening on screen I'm saving the page

Sorting_issue.mp4

@lukeholder
Copy link
Member

@WHITE-developer we have a potential fix for this on this PR: #3779

We are just testing it a little more before including it in a release.

@lukeholder lukeholder self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants