-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add safari not support modal #310
Conversation
✅ Deploy Preview for cn-devtools-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What is the point of dismissing the message? Wouldn't it be better to provide download links to different other browsers? |
Providing download links is a little savage haha. From my point of view, this is just a nice way of still letting people proceed if they want to try. Since the modal might still be shown in some weird wrong context. (Someone faking their user agent or something weird like that). The modal can also be closed by clicking next to it. The main problem is that the only thing that "breaks" DevTools right now is the weird behavior of Safari blocking requests to |
This PR adds a modal that will be displayed to all safari users notifying them that DevTools Web currently does not support safari:
Closes DT-51