Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add safari not support modal #310

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Conversation

johann-crabnebula
Copy link
Contributor

@johann-crabnebula johann-crabnebula commented Jun 6, 2024

This PR adds a modal that will be displayed to all safari users notifying them that DevTools Web currently does not support safari:

Screenshot 2024-06-10 at 16 48 37

Closes DT-51

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for cn-devtools-app ready!

Name Link
🔨 Latest commit 96a9df3
🔍 Latest deploy log https://app.netlify.com/sites/cn-devtools-app/deploys/6668feb7f692ec0008c8f2ea
😎 Deploy Preview https://deploy-preview-310--cn-devtools-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johann-crabnebula johann-crabnebula changed the title wip: add safari not support modal feat: add safari not support modal Jun 10, 2024
@alex-crabnebula
Copy link
Contributor

alex-crabnebula commented Jun 10, 2024

What is the point of dismissing the message? Wouldn't it be better to provide download links to different other browsers?

@johann-crabnebula
Copy link
Contributor Author

Providing download links is a little savage haha.

From my point of view, this is just a nice way of still letting people proceed if they want to try. Since the modal might still be shown in some weird wrong context. (Someone faking their user agent or something weird like that). The modal can also be closed by clicking next to it.

The main problem is that the only thing that "breaks" DevTools right now is the weird behavior of Safari blocking requests to localhost.

clients/web/src/views/connect.tsx Show resolved Hide resolved
@johann-crabnebula johann-crabnebula merged commit 60be226 into main Jun 12, 2024
6 checks passed
@johann-crabnebula johann-crabnebula deleted the feat/safari-not-supported branch June 12, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants