Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

White colors everywhere #97

Closed
ShalokShalom opened this issue Jul 16, 2019 · 16 comments
Closed

White colors everywhere #97

ShalokShalom opened this issue Jul 16, 2019 · 16 comments

Comments

@ShalokShalom
Copy link

What's the issue:

Readme files and issues in the homescreen are very bright

Steps to reproduce:

Install Github-Dark 2.0

Screenshots:

Screenshot_20190716_124330

Screenshot_20190716_124508

What version is affected by this problem:

Current, on Stylus

@snowe2010
Copy link
Contributor

Did you install Stylus using userstyles.org or using the user.css file in the root directory?

@ShalokShalom
Copy link
Author

I did install Stylus through the Firefox app-store?

And then, the theme via userstyles.org

@snowe2010
Copy link
Contributor

Yes, the theme is not updated on userstyles.org. See #86, #87, #93, #94, #95.

@ShalokShalom
Copy link
Author

ShalokShalom commented Jul 16, 2019

So, why are you recommending it in the Readme?

@snowe2010
Copy link
Contributor

We're not. The recommendation is to use the usercss.

How to use
Install a userstyle manager for your favorite browser:

Google Chrome
Firefox (be sure to place the CSS inside the @-moz-document domain("github.com") block, but is best to install as a userstyle)
Safari

@snowe2010
Copy link
Contributor

If you would like to update the documentation to make it more clear, since it appears to not be clear enough, feel free to make a pr and I will merge.

@ShalokShalom
Copy link
Author

@ShalokShalom
Copy link
Author

ShalokShalom commented Jul 16, 2019

I think the current way is super confusing. Why not simply carrying an own version on userstyles and let everyone installing with one click?

@snowe2010
Copy link
Contributor

Please read #86 and #87 for why.

@ShalokShalom
Copy link
Author

This says nothing why it is a bad idea to host our own version.

@snowe2010
Copy link
Contributor

What do you mean by our 'own' version.

@ShalokShalom
Copy link
Author

That we upload our own version on user styles..

I do that now.

@snowe2010
Copy link
Contributor

I think that will cause confusion. What happens when @cquanu comes back and begins updating the main userstyles.org again. It's much easier to use one click installs with usercss than with userstyles.org. We should be migrating away from userstyles.org for many reasons, the fact that it's not being updated is just one of them. I will update the readme.

snowe2010 added a commit that referenced this issue Jul 16, 2019
Remove userstyles.org instructions until cquanu comes back

Closes #97 and #99
@snowe2010
Copy link
Contributor

I have updated the readme. Let me know if that is more clear.

@ShalokShalom
Copy link
Author

What happens when @cquanu comes back and begins updating the main userstyles.org again.

Taking it down?

What happens if cquanu never comes back?

@snowe2010
Copy link
Contributor

@cquanu is on military leave.

I've updated the readme to clarify that userstyles will not be updated and should not be used.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants