Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 12.04 bug fixes. Python drivers class #2

Open
wants to merge 1 commit into
base: feature/master/align-with-puppetlabs-mysql
Choose a base branch
from
Open

Ubuntu 12.04 bug fixes. Python drivers class #2

wants to merge 1 commit into from

Conversation

etiennep
Copy link

Made a few changes to make it work on Ubuntu 12.04.

Added class to install python drivers/libs.

Added driver to install python driver/libs.
match => '^listen_addresses\s*=.*$',
line => "listen_addresses = '${listen_addresses}'",
notify => Service['postgresqld'],
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason that this file_line approach was not working for you? I was trying to avoid having to manage the entire file, because I'm concerned about compatibility between postgres 8.x and 9.x.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting an matching error and it was making the puppet run fail. I think I may have an old version of stdlib? Perhaps we could put separate templates for each version instead? That would also give more configuration options down the road.

Actually, I think the matcher didn't find anything because that line is preceded with a # in 9.1. Maybe I should revert and just try to fix the regex.

Found the problem. Issue with stdlibs. I've upgraded it and I am re-resting. I'll update the pull request later.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do templates for postgres.conf, then I like the idea of having a separate template for postgres 8 vs postgres 9.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Chris,

Are you still working on this module actively? I'm at a different company (MaestroDev) and I'd like to help you wrap this up if you're not done yet. We are using postgresql 9.0 on CentOS.

Etienne

On Jun 15, 2012, at 5:39 PM, Chris Price [email protected] wrote:

We must set a "listen_addresses" line in the postgresql.conf if we

want to allow any connections from remote hosts.

  • file_line { 'postgresql.conf':
  • path => $postgresql_conf_path,
  • match => '^listen_addresses\s_=._$',
  • line => "listen_addresses = '${listen_addresses}'",
  • notify => Service['postgresqld'],
  • }

If we do templates for postgres.conf, then I like the idea of having a separate template for postgres 8 vs postgres 9.


Reply to this email directly or view it on GitHub:
https://github.com/cprice-puppet/puppet-postgresql/pull/2/files#r996699

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we're just about to do a release to the forge. All of my work so far has been merged back into the original repo that I forked from, though... inkling/puppet-postgres. Feel free to email me to discuss further, we would love additional submissions!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My email is just chris@ puppetlabs if you don't have it already.

cprice404 pushed a commit that referenced this pull request Sep 12, 2012
…le-to-new-stdlib

Update Modulefile to reflect latest dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants