inappropriate files being installed into PERL5LIB [rt.cpan.org #99789]

[toddr]

Migrated from rt.cpan.org#99789 (status was 'open')

Requestors:

• [email protected]

From [email protected] on 2014-10-24 23:41:41
:

These files are being installed into PERL5LIB and do not belong there - they are not a .pod file that can be viewed with 'perldoc', nor do they contain executable code.

The proper location for supporting data files that accompany a distribution is in a sharedir -- use File::ShareDir::Install within Makefile.PL to set up the directory, and access the directory name from code using File::ShareDir.

From [email protected] on 2014-10-24 23:44:04
:

On 2014-10-24 16:41:41, ETHER wrote:
> These files are being installed into PERL5LIB and do not belong there
> - they are not a .pod file that can be viewed with 'perldoc', nor do
> they contain executable code.
> 
> The proper location for supporting data files that accompany a
> distribution is in a sharedir -- use File::ShareDir::Install within
> Makefile.PL to set up the directory, and access the directory name
> from code using File::ShareDir.


The file list:

lib/XML/Parser/Encodings/Japanese_Encodings.msg
lib/XML/Parser/Encodings/README
lib/XML/Parser/Encodings/big5.enc
lib/XML/Parser/Encodings/euc-kr.enc
lib/XML/Parser/Encodings/ibm866.enc
lib/XML/Parser/Encodings/iso-8859-2.enc
lib/XML/Parser/Encodings/iso-8859-3.enc
lib/XML/Parser/Encodings/iso-8859-4.enc
lib/XML/Parser/Encodings/iso-8859-5.enc
lib/XML/Parser/Encodings/iso-8859-7.enc
lib/XML/Parser/Encodings/iso-8859-8.enc
lib/XML/Parser/Encodings/iso-8859-9.enc
lib/XML/Parser/Encodings/koi8-r.enc
lib/XML/Parser/Encodings/windows-1250.enc
lib/XML/Parser/Encodings/windows-1251.enc
lib/XML/Parser/Encodings/windows-1252.enc
lib/XML/Parser/Encodings/windows-1255.enc
lib/XML/Parser/Encodings/x-euc-jp-jisx0221.enc
lib/XML/Parser/Encodings/x-euc-jp-unicode.enc
lib/XML/Parser/Encodings/x-sjis-cp932.enc
lib/XML/Parser/Encodings/x-sjis-jdk117.enc
lib/XML/Parser/Encodings/x-sjis-jisx0221.enc
lib/XML/Parser/Encodings/x-sjis-unicode.enc

From [email protected] on 2014-12-14 07:35:22
:

On Fri Oct 24 19:44:04 2014, ETHER wrote:
> On 2014-10-24 16:41:41, ETHER wrote:
> > These files are being installed into PERL5LIB and do not belong there
> > - they are not a .pod file that can be viewed with 'perldoc', nor do
> > they contain executable code.

Actually per the README:

This directory contains binary encoding maps for some selected encodings.
If they are placed in a directory listed in @XML::Parser::Expat::Encoding_Path,
then they are automatically loaded by the XML::Parser::Expat::load_encoding
function as needed. Otherwise you may load what you need directly by
explicitly calling this function.

This was not my doing so I lack background on this stuff. I suspect it would require a significant change to make this work and I am suspicious that I would end up breaking downstream distros of this module by doing so or who ship additional or altered encodings.

Other than that it's annoying, what is the problem you're trying to solve?

[toddr]

@ether Other than that it's annoying, what is the problem you're trying to solve?

[toddr]

I agree these should be moved to share_dir. This is complicated by having multiple Makefile.PL files but it should be sortable.