-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question on sum(w) #65
Comments
It's normal for the sum of event weight to be different of the number of processed event. The number of processed event is the number of event going though the
|
ok, I see, in that case we need a fix: the sum(w) is supposed to be running on all events 'good for physics' (ie not rejected from filters throwing away crazy met or buggy mc events).... but in any I am still not sure I understand all the code then: I understood the sum(w) is taken care of by the event producer, this is run before the analyzers ? |
Yes indeed, filters are ran before the producers and the event weight will be incorrect if some event are dropped. I need to find a correct way to handle that, since we also have some filters running directly inside CMSSW. The sum is indeed computed by the event producer, which is run, like all producers, before the analyzers and categories. If you forget filters, you are assured that the event producer is called on every events. |
ok, so one thing we may have to be careful of is that filters are really only filtering out 'buggy' events (in case some day we have a preselection filter...) |
While discussing GridIn with @swertz we ran into this log:
(full log at
/storage/data/cms/store/user/swertz/MuonEG/MuonEG_Run2015C-PromptReco-v1_2015-09-04/150922_085937/0000/log/cmsRun_1.log.tar.gz
)given this is data I am not sure I understand why sum(w) != nprocessed... from #22 I expect they should be the exact same, but since recently the met filter is run before the producer, could this be the reason ?
also, from the log it seems
event
enters second in the scheduling sequence, which could be a possible reason:The text was updated successfully, but these errors were encountered: