-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Refresh/reset button to push all status to WLED #34
Comments
Less bug, more intentional and the way OctoPrint's event system works. Yes it could probably be clearer how this works, for sure. Each of the effects you get to see in the settings is event-driven. It will only send requests across the network to change the LEDs, when there is a new effect. The printing progress event is obviously changing far more frequently, but it still works the same way, it will only change if there is a new data. Modifying the configuration is also treated this way, it actually replays the last event to make sure WLED is up to date with the changes made in the OctoPrint settings. I want to work on it a bit more to make the behaviour consistent, but I'm not going to constantly push the last event back to the printer all the time. As it stands, the plugin allows for a lot of freedom with doing other things with your WLED device. TL,DR; Yes, there is something to be done but I haven't decided what to do about it yet. Added just before I hit comment: Maybe a button to refresh the LED strip, with whatever the plugin thinks should be on there currently. I'll think about it 🙂 |
Hi Charlie,
thanks a lot for your answer and thanks for the great plugin!
I'd appreciate a 'Refresh' button... ;-)
Best Regards,
Stefan
Gesendet: Freitag, 30. April 2021 um 00:13 Uhr
Von: "Charlie Powell" ***@***.***>
An: "cp2004/OctoPrint-WLED" ***@***.***>
Cc: "SVLoneStar" ***@***.***>, "Author" ***@***.***>
Betreff: Re: [cp2004/OctoPrint-WLED] [Bug] (#34)
Less bug, more intentional and the way OctoPrint's event system works. Yes it could probably be clearer how this works, for sure.
Each of the effects you get to see in the settings is event-driven. It will only send requests across the network to change the LEDs, when there is a new effect. The printing progress event is obviously changing far more frequently, but it still works the same way, it will only change if there is a new data. Modifying the configuration is also treated this way, it actually replays the last event to make sure WLED is up to date with the changes made in the OctoPrint settings.
I want to work on it a bit more to make the behaviour consistent, but I'm not going to constantly push the last event back to the printer all the time. As it stands, the plugin allows for a lot of freedom with doing other things with your WLED device.
TL,DR; Yes, there is something to be done but I haven't decided what to do about it yet.
Added just before I hit comment: Maybe a button to refresh the LED strip, with whatever the plugin thinks should be on there currently. I'll think about it 🙂
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
When switching on the WLED Wemos in the middle of a print, status is not fully synched to the LED stripe.
I have 3 segments defined...the one configured to show the printing progress gets updated, but the other two (meant to show status 'printing') are left to the previous pattern (whatever that was).
Steps to reproduce
What did you expect to happen
I'd expect that ever so often, the complete configuration for the stripe gets sent to the WLED Wemos, and not only updates for the 'Progress Effect' are being sent.
Logs and screenshots
Version of plugin and OctoPrint
OctoPrint 1.6.0, WLED plugin 0.1.0
(If applicable) Browser version & browser error console
Additional context
Updating the complete stripe by switching on/off the plugin in OctoPrint's top bar would be sufficient for me. ;-)
Modifying the configuration and saving it updates the complete stripe, also mid-print.
The text was updated successfully, but these errors were encountered: