Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Make the navbar switch stateful #149

Open
cbrherms opened this issue Dec 16, 2021 · 2 comments
Open

[Feature Request] Make the navbar switch stateful #149

cbrherms opened this issue Dec 16, 2021 · 2 comments
Labels
request New feature or request

Comments

@cbrherms
Copy link

Is your feature request related to a problem? Please describe.

Navbar button is stateless and so does not sync with current state of the WLED instance.
If for example you make use of the terminal commands to turn the lights on or off via another plugin or gcode, the navbar button does not reflect this change.

Describe the solution you'd like

Would be best if the on state of WLED was monitored and the navbar switch was correct for this status.
Failing that, having the @WLED gcode commands change the state of the navbar

Why should this be implemented?

At present, with the switch having two colours for on/off it implies there is some knowledge of state and when that fails it doesn't appear as good from a UX point of view. This wouldn't be as much of an issue if it was the only method of toggling the lights but with there being the command method it's easy to get to a point where it is wrongly showing the wrong state on the navbar

Additional context

@cp2004
Copy link
Owner

cp2004 commented Dec 16, 2021

This is semi-bug and semi new feature. The navbar button should be syncing with things like the @WLED commands, and if you have it open on more than one tab, but I just looked and the code for that is missing the one final part in the frontend - the messages are sent, but nothing is done...

That's the bug part. Syncing with external WLED changes is more complicated and not intended to work yet, but still doable if I wanted it. WLED has a websocket I can connect to, and a newer version of the library that I'm using (modified) has support for that.

It will take a long time regardless - I don't currently have the time to work on any of my projects, hopefully in the new year there will be good things coming...

@cbrherms
Copy link
Author

No problem.
I was unsure whether to report it as bug or feature so thanks for clarifying.

@cp2004 cp2004 added the request New feature or request label Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants