Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] ensure that URLs are not logged by requests on errors #178

Open
cp2004 opened this issue Jul 26, 2022 · 0 comments
Open

[Request] ensure that URLs are not logged by requests on errors #178

cp2004 opened this issue Jul 26, 2022 · 0 comments
Labels
request New feature or request

Comments

@cp2004
Copy link
Owner

cp2004 commented Jul 26, 2022

What would you like implemented?

In some cases where a network request can encounter an error, just logging the exception from requests is not good enough because this contains the URL that it was trying to access. For upload sessions, this URL is unique and while it should expire so there is no security compromise, log files shouldn't really contain stuff like this.

All access tokens used are never logged as they are securely contained in request headers.

Thought of while looking at #175

@cp2004 cp2004 added the request New feature or request label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant