You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should also consider completely removing executedSellAmountBeforeFees as I believe frontend is using only executedSellAmount for these legacy orders.
Background
Once all executed fees are in the same token (surplus token), we can show following in the API:
as there are no clients that are interested in
executedFeeAmount
solely, and also, this field is only kept for legacy orders.This effectively means we can remove
executedFeeAmount
from API.Acceptance criteria
There is only ONE fee in the API that represents the total fee that was taken for execution of an order, and it's called
executedFee
.The text was updated successfully, but these errors were encountered: