Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Completely remove executedFeeAmount from API #3232

Open
sunce86 opened this issue Jan 10, 2025 · 1 comment
Open

chore: Completely remove executedFeeAmount from API #3232

sunce86 opened this issue Jan 10, 2025 · 1 comment

Comments

@sunce86
Copy link
Contributor

sunce86 commented Jan 10, 2025

Background

Once all executed fees are in the same token (surplus token), we can show following in the API:

  1. executedFee = executedFee + executedFeeAmount
  2. executedFeeAmount = 0 for ALL orders

as there are no clients that are interested in executedFeeAmount solely, and also, this field is only kept for legacy orders.

This effectively means we can remove executedFeeAmount from API.

Acceptance criteria

There is only ONE fee in the API that represents the total fee that was taken for execution of an order, and it's called executedFee.

@sunce86
Copy link
Contributor Author

sunce86 commented Jan 10, 2025

We should also consider completely removing executedSellAmountBeforeFees as I believe frontend is using only executedSellAmount for these legacy orders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant