Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When resetting password, new password can't be same as curreent password #416

Open
jcolla-holla opened this issue Jul 28, 2020 · 1 comment · Fixed by #419
Open

When resetting password, new password can't be same as curreent password #416

jcolla-holla opened this issue Jul 28, 2020 · 1 comment · Fixed by #419
Milestone

Comments

@jcolla-holla
Copy link
Contributor

From Jeff

@ibeckermayer
Copy link
Contributor

Resolved for ResetPasswordModal.js, but still needs to be solved for ChangePasswordModal.js.

This is a bit trickier -- I think the best way to do this is to try and login with the user's username/new-pass, and if it works then we complain at them (since it means that new-pass is the same as old-pass). This might be done on the frontend, however it could cause some sluggishness by triggering the __authStateListener in store/index.js. If that's the case, then we can make this check a cloud function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants