Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against supported ruby versions #39

Closed
AlexMooney opened this issue Apr 23, 2020 · 0 comments
Closed

Test against supported ruby versions #39

AlexMooney opened this issue Apr 23, 2020 · 0 comments

Comments

@AlexMooney
Copy link

Ruby 2.3 and 2.4 are both EOL'd, so it's time to update CI. https://www.ruby-lang.org/en/downloads/branches/.

sql_footprint/.travis.yml

Lines 7 to 9 in 90d33b4

rvm:
- 2.3
- 2.4

Not sure what CMM is on these days, but I hope you have upgraded past these. 😆

Would fix CI for #36 too.
davidmyersdev pushed a commit that referenced this issue Apr 27, 2020
Add supported Ruby versions - close #39
6269c30
davidmyersdev added a commit that referenced this issue Apr 27, 2020
@davidmyersdev
Add supported Ruby versions - close #39
8d07f5f
davidmyersdev added a commit that referenced this issue Apr 28, 2020
@davidmyersdev
Add supported Ruby versions - close #39
ea5cd9e 
The specs were failing on newer versions of Ruby due to ActiveRecord 6. There was a hardcoded check for version 5, and this was causing a conditional spec to fallback to version 4. The spec has been updated to now test accordingly when the version is either below or above 5 (this is where the actual distinction lies).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexMooney