From 80775cea7ae37ad0a7addf829489ea3fbcb05ef7 Mon Sep 17 00:00:00 2001 From: Gregory Newman-Smith <109068393+gregns1@users.noreply.github.com> Date: Tue, 29 Oct 2024 11:12:10 +0000 Subject: [PATCH] CBG-4242: TestReleaseSequenceOnDocWriteFailure flake (#7172) * CBG-4242: TestReleaseSequenceOnDocWriteFailure flake * remove test skip on rebase --- db/crud_test.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/db/crud_test.go b/db/crud_test.go index ecbb2475cd..46818cf362 100644 --- a/db/crud_test.go +++ b/db/crud_test.go @@ -1691,9 +1691,6 @@ func TestAssignSequenceReleaseLoop(t *testing.T) { // - Write new doc with conflict error // - Assert we release a sequence for this func TestReleaseSequenceOnDocWriteFailure(t *testing.T) { - if !base.UnitTestUrlIsWalrus() { - t.Skip("skipping for CBS pending CBG-4242") - } defer SuspendSequenceBatching()() base.SetUpTestLogging(t, base.LevelDebug, base.KeyAll) @@ -1701,10 +1698,8 @@ func TestReleaseSequenceOnDocWriteFailure(t *testing.T) { var db *Database var forceDocConflict bool - const ( - conflictDoc = "doc1" - timeoutDoc = "doc" - ) + conflictDoc := t.Name() + "_conflict" + timeoutDoc := t.Name() + "_timeout" // call back to create a conflict mid write and force a non timeout error upon write attempt writeUpdateCallback := func(key string) {